Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the dynamic fee tx and support for typed txs #903

Open
wants to merge 19 commits into
base: release/galactica
Choose a base branch
from

Conversation

paologalligit
Copy link
Member

@paologalligit paologalligit commented Nov 29, 2024

Description

This PR refers to a part of the dynamic fee market feature and it introduces a new typed transaction: DynamicFeeTransaction. This also allows the introduction of new transaction types. The typed tx model follows the EIP-2718.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Unit tests [still in progress]
  • Integration tests [still in progress]

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing E2E tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 70.06803% with 132 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/galactica@effd7f5). Learn more about missing BASE report.

Files with missing lines Patch % Lines
tx/transaction.go 42.85% 96 Missing and 4 partials ⚠️
tx/tx_dynamic_fee.go 83.33% 9 Missing and 2 partials ⚠️
tx/hashing.go 10.00% 9 Missing ⚠️
tx/builder.go 93.10% 4 Missing ⚠️
cmd/thor/solo/solo.go 40.00% 2 Missing and 1 partial ⚠️
tx/tx_legacy.go 94.73% 3 Missing ⚠️
api/transactions/types.go 50.00% 0 Missing and 1 partial ⚠️
cmd/thor/node/tx_stash.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##             release/galactica     #903   +/-   ##
====================================================
  Coverage                     ?   60.98%           
====================================================
  Files                        ?      224           
  Lines                        ?    23818           
  Branches                     ?        0           
====================================================
  Hits                         ?    14525           
  Misses                       ?     8124           
  Partials                     ?     1169           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paologalligit paologalligit changed the base branch from master to feat/dynamic-fee-market November 29, 2024 13:40
tx/builder.go Outdated Show resolved Hide resolved
tx/hashing.go Outdated Show resolved Hide resolved
tx/transaction.go Outdated Show resolved Hide resolved
tx/transaction.go Outdated Show resolved Hide resolved
tx/transaction.go Show resolved Hide resolved
api/transactions/types.go Outdated Show resolved Hide resolved
@paologalligit paologalligit changed the base branch from feat/dynamic-fee-market to master December 4, 2024 09:18
logdb/logdb_test.go Outdated Show resolved Hide resolved
tx/transaction.go Outdated Show resolved Hide resolved
@paologalligit paologalligit changed the base branch from master to feat/dynamic-fee-market December 5, 2024 09:33
@paologalligit paologalligit changed the base branch from feat/dynamic-fee-market to master December 5, 2024 09:49
api/transactions/transactions_test.go Show resolved Hide resolved
tx/transaction.go Outdated Show resolved Hide resolved
tx/transaction.go Show resolved Hide resolved
@paologalligit paologalligit marked this pull request as ready for review December 6, 2024 08:27
@paologalligit paologalligit requested a review from a team as a code owner December 6, 2024 08:27
@paologalligit paologalligit changed the base branch from master to feat/dynamic-fee-market December 9, 2024 08:56
tx/transaction.go Outdated Show resolved Hide resolved
tx/signer_test.go Outdated Show resolved Hide resolved
tx/builder_dynamic_fee.go Outdated Show resolved Hide resolved
tx/transaction.go Outdated Show resolved Hide resolved
tx/transaction.go Outdated Show resolved Hide resolved
@paologalligit paologalligit changed the base branch from feat/dynamic-fee-market to release/galactica January 14, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants