Ethers and ts refactor #60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with forked version for now)
… it into tests in order to not fail
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Esteemed Team Members,
I hope this message finds you well. It is my pleasure to announce that a new pull request has been created, targeting to enhance the project by upgrading the Typescript version and the Ethers. The goal has been pursued by substituting
vechain/etherswith the most recent version ofethers. A few lines have also been replaced byweb3.Please Note: In a bid to validate the new modifications and ensure that no regression bugs are introduced, I have incorporated some regression tests into this pull request. You may execute these tests by running the following command:
npm run test:regression_check.It's worth mentioning that the aforementioned tests are currently temporary, and can be removed or maintained based on our collective decision. Kindly review the pull request at your earliest convenience and make a decision on whether to approve the changes or not. If approved, we can further deliberate on whether to remove these tests or keep them in place for possible future modifications.
Looking forward to hearing your constructive feedback. Thank you in advance for your time and attention.
Best Regards,
Rodolfo