H2 minor fixes #4246
Merged
H2 minor fixes #4246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should never be scheduled when on H2_S_CLOSED state.
For PU upgrade, at the time of this log, the req->vsl is not assigned a vxid yet, and thus the line would be logged for vxid 0, which doen't make much sense. In all cases, it is better to log it on the sess vsl instead. Noticed while reading a vtc output.
dridi
approved these changes
Jan 2, 2025
We only transition to $ grep -rniI "H2_S_CLOSED" -C 4
bin/varnishd/http2/cache_http2_proto.c-625- h2 = r2->h2sess;
bin/varnishd/http2/cache_http2_proto.c-626- CHECK_OBJ_NOTNULL(h2, H2_SESS_MAGIC);
bin/varnishd/http2/cache_http2_proto.c-627- Lck_Lock(&h2->sess->mtx);
bin/varnishd/http2/cache_http2_proto.c-628- r2->scheduled = 0;
bin/varnishd/http2/cache_http2_proto.c:629: r2->state = H2_S_CLOSED;
bin/varnishd/http2/cache_http2_proto.c-630- r2->h2sess->do_sweep = 1;
bin/varnishd/http2/cache_http2_proto.c-631- Lck_Unlock(&h2->sess->mtx);
bin/varnishd/http2/cache_http2_proto.c-632- }
bin/varnishd/http2/cache_http2_proto.c-633- THR_SetRequest(NULL);
--
bin/varnishd/http2/cache_http2_proto.c-715- req->task->priv = req;
bin/varnishd/http2/cache_http2_proto.c-716- r2->scheduled = 1;
bin/varnishd/http2/cache_http2_proto.c-717- if (Pool_Task(wrk->pool, req->task, TASK_QUEUE_STR) != 0) {
bin/varnishd/http2/cache_http2_proto.c-718- r2->scheduled = 0;
bin/varnishd/http2/cache_http2_proto.c:719: r2->state = H2_S_CLOSED;
bin/varnishd/http2/cache_http2_proto.c-720- return (H2SE_REFUSED_STREAM); //rfc7540,l,3326,3329
bin/varnishd/http2/cache_http2_proto.c-721- }
bin/varnishd/http2/cache_http2_proto.c-722- return (0);
bin/varnishd/http2/cache_http2_proto.c-723-}
--
bin/varnishd/http2/cache_http2_proto.c-1413- assert (r2->state == H2_S_IDLE);
bin/varnishd/http2/cache_http2_proto.c-1414- continue;
bin/varnishd/http2/cache_http2_proto.c-1415- }
bin/varnishd/http2/cache_http2_proto.c-1416- switch (r2->state) {
bin/varnishd/http2/cache_http2_proto.c:1417: case H2_S_CLOSED:
bin/varnishd/http2/cache_http2_proto.c-1418- AZ(r2->scheduled);
bin/varnishd/http2/cache_http2_proto.c-1419- h2_del_req(wrk, r2);
bin/varnishd/http2/cache_http2_proto.c-1420- break;
bin/varnishd/http2/cache_http2_proto.c-1421- case H2_S_CLOS_REM: |
|
@walid-git with that compelling argument we do not need much of a review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two minor fixes, see commit logs for details.