vav: fix issues and improve tests #4021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, vav_test always passes make check
Output before: PASS: <> with flags 7 as expected. PASS: <foo> with flags 0 as expected. PASS: <foo bar> with flags 0 as expected. PASS: <foo bar> with flags 2 as expected. PASS: <foo,bar> with flags 2 as expected. PASS: < foo bar > with flags 0 as expected. PASS: < foo , bar > with flags 2 as expected. PASS: <foo bar > with flags 2 as expected. PASS: <foo,bar,> with flags 2 as expected. PASS: <foo "bar baz"> with flags 0 as expected. PASS: <foo #bar> with flags 0 as expected. PASS: <foo #bar> with flags 1 as expected. PASS: <foo#bar> with flags 0 as expected. PASS: <foo#bar> with flags 1 as expected. PASS: <\> with flags 4 as expected. PASS: <\x20> with flags 0 as expected. PASS: <foo"bar> with flags 4 as expected. PASS: <"foo""bar"> with flags 4 as expected. Output after: PASS: <> with flags 7 as expected. PASS: <foo> with flags 0 as expected. PASS: <foo bar> with flags 0 as expected. PASS: <foo bar> with flags 2 as expected. PASS: <foo,bar> with flags 2 as expected. PASS: < foo bar > with flags 0 as expected. PASS: < foo , bar > with flags 2 as expected. PASS: <foo bar > with flags 2 as expected. PASS: <foo,bar,> with flags 2 as expected. PASS: <foo "bar baz"> with flags 0 as expected. PASS: <foo #bar> with flags 0 as expected. PASS: <foo #bar> with flags 1 as expected. PASS: <foo#bar> with flags 0 as expected. PASS: <foo#bar> with flags 1 as expected. PASS: <\> with flags 4 as expected. FAIL: <\> with flags 0 as expected. FAIL: <\x> with flags 0 as expected. FAIL: <\x2> with flags 0 as expected. FAIL: <\x2O> with flags 0 as expected. PASS: <\x20> with flags 0 as expected. FAIL: <"foo> with flags 0 as expected. PASS: <foo"bar> with flags 4 as expected. FAIL: <foo"bar> with flags 0 as expected. FAIL: <foo"bar> with flags 0 as expected. PASS: <"foo""bar"> with flags 4 as expected. FAIL: <"foo""bar"> with flags 0 as expected.
Cli command '"help" "help"' was wrongly rejected with error message: "Missing separator between arguments"
dridi
approved these changes
Nov 20, 2023
|
Bugwash: ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves
vav_testand fixes two issues inVAV_ParseTxt:vav_testwas always returning 0, which makes it always pass make check. Failed tests as expected were not printed in the final report. And the test suite was aborting as soon as a single test would fail.VAV_ParseTxtwas not correctly handling"foo" "bar"with no flags, and"foo", "bar"with the ARGV_COMMA flag.