Loop over FDs if close_range fails. #3989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
dridi
requested changes
Oct 16, 2023
lib/libvarnish/vsub.c
Outdated
Comment on lines
41
to
43
| #ifdef HAVE_WORKING_CLOSE_RANGE | ||
| #elif HAVE_CLOSEFROM | ||
| #else | ||
| # include <dirent.h> | ||
| #ifndef HAVE_CLOSEFROM | ||
| #include <dirent.h> | ||
| #endif |
There was a problem hiding this comment.
Please bring back the # include indentation, it's nested inside an #ifdef.
simonvik
force-pushed
the
continueoncloserange
branch
from
af04219 to
48ecb03
Compare
dridi
approved these changes
Oct 16, 2023
|
The failure for the ASAN job is a test case taking more than a minute, so not timing out stuck somewhere in the script. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close_rangeis still a somewhat new function and its common that the userspace in a container is newer than the kernel.This fixes #3988