Skip to content

Commit

Permalink
param: Deprecate default for bits parameters
Browse files Browse the repository at this point in the history
We have had the ability to reset any parameter to its default value for
a while now.
  • Loading branch information
dridi committed Nov 14, 2023
1 parent 61c7cc4 commit cb6a584
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
1 change: 1 addition & 0 deletions bin/varnishd/mgt/mgt_param_tweak.c
Original file line number Diff line number Diff line change
Expand Up @@ -678,6 +678,7 @@ tweak_generic_bits(struct vsb *vsb, const struct parspec *par, const char *arg,
unsigned j;

if (arg != NULL && !strcmp(arg, "default")) {
/* XXX: deprecated in favor of param.reset */
return (tweak_generic_bits(vsb, par, par->def, p, l, tags,
desc, sign));
}
Expand Down
6 changes: 3 additions & 3 deletions include/tbl/params.h
Original file line number Diff line number Diff line change
Expand Up @@ -1834,7 +1834,7 @@ PARAM_BITS(
"+vcl_req_reset",
/* descr */
"Enable/Disable various minor features.\n"
"\tdefault\tSet default value\n"
"\tdefault\tSet default value (deprecated: use param.reset)\n"
"\tnone\tDisable all features.\n\n"
"Use +/- prefix to enable/disable individual feature:")
#ifdef PARAM_ALL
Expand All @@ -1853,7 +1853,7 @@ PARAM_BITS(
"+unsafe_path",
/* descr */
"Enable/Disable various VCC behaviors.\n"
"\tdefault\tSet default value\n"
"\tdefault\tSet default value (deprecated: use param.reset)\n"
"\tnone\tDisable all behaviors.\n\n"
"Use +/- prefix to enable/disable individual behavior:")
#ifdef PARAM_ALL
Expand Down Expand Up @@ -1885,7 +1885,7 @@ PARAM_BITS(
/* descr */
"Mask individual VSL messages from being logged.\n"
"\tall\tEnable all tags\n"
"\tdefault\tSet default value\n"
"\tdefault\tSet default value (deprecated: use param.reset)\n"
"\nUse +/- prefix in front of VSL tag name to unmask/mask "
"individual VSL messages.")
PARAM_POST
Expand Down

0 comments on commit cb6a584

Please sign in to comment.