Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update PR template and CONTRIBUTING guide to GitHub Flow #777

Closed
wants to merge 2 commits into from

Conversation

gl3nng0uld
Copy link

Proposed changes

From the recent development activity, I found that the project adopts the GitHub Flow: branching off from main, and then merge in main again.

Instead, both the PR template .github/pull_request_template.md and the CONTRIBUTING.md guide say to create a new branch from develop and to never do a pull request directly on main.

Am I wrong? If so, please close this PR.

Fixes

n/a

Types of changes

What types of changes does your code introduce to agents-aea?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Lint and unit tests pass locally with my changes and CI passes too
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that code coverage does not decrease.
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

n/a

.github/pull_request_template.md Outdated Show resolved Hide resolved
@Adamantios Adamantios added the documentation Improvements or additions to documentation label Jan 22, 2025
@gl3nng0uld gl3nng0uld closed this Jan 22, 2025
Adamantios added a commit that referenced this pull request Jan 23, 2025
fix: update PR template and CONTRIBUTING guide to GitHub Flow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants