Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(colors): remove some deprecated colors #6415

Merged
merged 6 commits into from
Jan 15, 2025
Merged

Conversation

kathaypacific
Copy link
Collaborator

Description

This PR removes the following colors:

  • error (replace with errorDark)
  • ivory (replace with gray1)
  • accentDisabled (since this is technically part of the colors, i just inlined the opacity in the 2 places that need it)
  • goldBrand (it wasn't being used except in a loading indicator, which i changed to accent like most other loaders)
  • infoLight (replace with successLight, it is part of the dapp claim shortcuts card and is not so important)

Test plan

n/a

Related issues

Backwards compatibility

Y

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

@@ -164,11 +161,7 @@ export default function CurrencyDisplay({
const code = displayAmount?.currencyCode
const fullCurrencyName = getFullCurrencyName(amountCurrency)

const color = useColors
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useColors defaulted to false and wasn't being set to true anywhere

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.12%. Comparing base (ffd0eaf) to head (ff61d3a).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6415   +/-   ##
=======================================
  Coverage   89.11%   89.12%           
=======================================
  Files         737      737           
  Lines       31887    31876   -11     
  Branches     6053     6050    -3     
=======================================
- Hits        28416    28408    -8     
+ Misses       3275     3273    -2     
+ Partials      196      195    -1     
Files with missing lines Coverage Δ
src/backup/QuizzBottom.tsx 90.00% <ø> (ø)
src/components/CircleButton.tsx 100.00% <ø> (ø)
src/components/CodeInput.tsx 100.00% <ø> (ø)
src/components/CurrencyDisplay.tsx 67.21% <100.00%> (+0.80%) ⬆️
src/components/DevSkipButton.tsx 76.66% <ø> (ø)
src/components/ErrorMessageInline.tsx 92.00% <ø> (ø)
src/components/PercentageIndicator.tsx 100.00% <100.00%> (ø)
src/components/SmartTopAlert.tsx 79.03% <ø> (ø)
src/dapps/DappShortcutsRewards.tsx 97.22% <100.00%> (ø)
src/earn/poolInfoScreen/SafetyCard.tsx 100.00% <100.00%> (ø)
... and 9 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffd0eaf...ff61d3a. Read the comment docs.

Copy link
Member

@jeanregisser jeanregisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kathaypacific kathaypacific added this pull request to the merge queue Jan 15, 2025
@kathaypacific kathaypacific removed this pull request from the merge queue due to a manual request Jan 15, 2025
@kathaypacific kathaypacific merged commit 70f2708 into main Jan 15, 2025
15 checks passed
@kathaypacific kathaypacific deleted the kathy/palette-7 branch January 15, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants