-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(colors): remove some deprecated colors #6415
Conversation
@@ -164,11 +161,7 @@ export default function CurrencyDisplay({ | |||
const code = displayAmount?.currencyCode | |||
const fullCurrencyName = getFullCurrencyName(amountCurrency) | |||
|
|||
const color = useColors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
useColors
defaulted to false and wasn't being set to true anywhere
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6415 +/- ##
=======================================
Coverage 89.11% 89.12%
=======================================
Files 737 737
Lines 31887 31876 -11
Branches 6053 6050 -3
=======================================
- Hits 28416 28408 -8
+ Misses 3275 3273 -2
+ Partials 196 195 -1
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Description
This PR removes the following colors:
accent
like most other loaders)Test plan
n/a
Related issues
Backwards compatibility
Y
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: