-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(colors): remove white and replace with semantic counterparts #6409
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6409 +/- ##
==========================================
- Coverage 89.12% 89.11% -0.01%
==========================================
Files 737 737
Lines 31876 31881 +5
Branches 5743 6052 +309
==========================================
+ Hits 28408 28412 +4
+ Misses 3421 3274 -147
- Partials 47 195 +148
... and 58 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
src/styles/colors.tsx
Outdated
|
||
// borders, shadows, highlights | ||
shadow = '#2E3338', | ||
softShadow = 'rgba(156, 164, 169, 0.4)', | ||
lightShadow = 'rgba(48, 46, 37, 0.15)', | ||
barShadow = 'rgba(129, 134, 139, 0.5)', | ||
loadingSkeletonHighlight = '#FFFFFF', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
supernit: wondering if we should use skeletonPlaceholderHighlight
?
Unless maybe we wanna add more things prefixed with loading
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes sorry it's not clear here but i will also create a color for the loading indicator, although the spinner doesn't have to be directly related to the skeleton loader. i can rename it!
Description
This PR:
Test plan
N/a
Related issues
Backwards compatibility
Y
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: