Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(colors): remove white and replace with semantic counterparts #6409

Merged
merged 24 commits into from
Jan 15, 2025

Conversation

kathaypacific
Copy link
Collaborator

@kathaypacific kathaypacific commented Jan 13, 2025

Description

This PR:

  • remove Colors.white
  • use "background" when white was used for background color styles
  • use "textInverse" for any text that was set to white
  • use "loadingSkeletonHighlight" for the skeleton loader

Test plan

N/a

Related issues

Backwards compatibility

Y

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.11%. Comparing base (70f2708) to head (59f35f6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/qrcode/QRTabBar.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6409      +/-   ##
==========================================
- Coverage   89.12%   89.11%   -0.01%     
==========================================
  Files         737      737              
  Lines       31876    31881       +5     
  Branches     5743     6052     +309     
==========================================
+ Hits        28408    28412       +4     
+ Misses       3421     3274     -147     
- Partials       47      195     +148     
Files with missing lines Coverage Δ
src/account/ShakeForSupport.tsx 86.48% <ø> (ø)
src/backup/BackupIntroduction.tsx 90.00% <ø> (ø)
src/celoNews/CeloNewsFeedItem.tsx 100.00% <100.00%> (ø)
src/components/BottomSheetLegacy.tsx 95.74% <ø> (ø)
src/components/Button.tsx 100.00% <100.00%> (ø)
src/components/Card.tsx 100.00% <ø> (ø)
src/components/CircleButton.tsx 100.00% <100.00%> (ø)
src/components/ClipboardAwarePasteButton.tsx 78.26% <ø> (ø)
src/components/CodeRow.tsx 97.50% <ø> (ø)
src/components/Dropdown.tsx 100.00% <ø> (ø)
... and 68 more

... and 58 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70f2708...59f35f6. Read the comment docs.

Base automatically changed from kathy/palette-1 to main January 15, 2025 10:54
Copy link
Member

@jeanregisser jeanregisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀


// borders, shadows, highlights
shadow = '#2E3338',
softShadow = 'rgba(156, 164, 169, 0.4)',
lightShadow = 'rgba(48, 46, 37, 0.15)',
barShadow = 'rgba(129, 134, 139, 0.5)',
loadingSkeletonHighlight = '#FFFFFF',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

supernit: wondering if we should use skeletonPlaceholderHighlight?
Unless maybe we wanna add more things prefixed with loading?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes sorry it's not clear here but i will also create a color for the loading indicator, although the spinner doesn't have to be directly related to the skeleton loader. i can rename it!

@kathaypacific kathaypacific added this pull request to the merge queue Jan 15, 2025
@kathaypacific kathaypacific removed this pull request from the merge queue due to a manual request Jan 15, 2025
@kathaypacific kathaypacific merged commit bc4c9ac into main Jan 15, 2025
15 checks passed
@kathaypacific kathaypacific deleted the kathy/palette-2 branch January 15, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants