feat(ci): Add knip, remove depcheck #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanregisser
approved these changes
Nov 2, 2023
cajubelt
approved these changes
Nov 2, 2023
silasbw
reviewed
Nov 2, 2023
| @@ -0,0 +1,5 @@ | |||
| { | |||
| "entry": ["src/index.ts"], | |||
| "project": ["src/**/*/.ts"], | |||
There was a problem hiding this comment.
should this include scripts/?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a (kind of lame) initial configuration for knip, which replaces depcheck. By default, this will report on a lot of useful stuff, so may require further tuning/configuration as we learn how to use it preoperly.
(While getting this PR ready,
knipactually complained to me after Iyarn remove'ddepcheckbut before I updated the GH workflow to useknipinstead ofdepcheck. It was able to detect that withoutdepcheckinstalled, there was no such binary nameddepcheckavailable in the package, which we were still referencing in the GH workflow -- kind of wild!!)