Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datepicker): update hr.ts date separation from '/' to '.' #6447

Merged
merged 4 commits into from
Oct 18, 2024

Conversation

vrbaaa
Copy link
Contributor

@vrbaaa vrbaaa commented Mar 28, 2022

change date separation from slashes (/) to dots (.)

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

vrbaaa and others added 2 commits March 28, 2022 12:57
change date separation from slashes (/) to dots (.)
Copy link
Member

@valorkin valorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this is correct https://www.localeplanet.com/icu/hr-HR/index.html
thanks for your help

@cypress
Copy link

cypress bot commented Jun 16, 2022



Test summary

800 32 14 0


Run details

Project ngx-bootstrap
Status Failed
Commit 2b00831 ℹ️
Started Jun 16, 2022 10:10 AM
Ended Jun 16, 2022 10:45 AM
Duration 34:59 💡
OS Linux Ubuntu - 20.04
Browser Electron 93

View run in Cypress Dashboard ➡️


Failures

typeahead_page_spec.ts Failed
1 Typeahead demo page testing suite > On blur > clicking anywhere outside auto-fills "Option on blur" with the first option from the matches list
datepicker/locales_spec.ts Failed
1 Datepicker demo testing suite: Locales > Change Locale Datepicker > when user chose locale es-pr for "Datepicker", container shown in appropriate language
2 Datepicker demo testing suite: Locales > Change Locale DateRangepicker > when user chose locale es-pr for "Daterangepicker", container shown in this language
modals_service_page_spec.ts Failed
1 Modals demo page testing suite: Service examples > Nested modals > when user clicks on the button "Open second modal" then the second modal with title "Second modal" is opened, "Close self" is present
2 Modals demo page testing suite: Service examples > Events > when user closes modal by click on the cross then should be messages "onHide event has been fired" and "onHidden event has been fired"
3 Modals demo page testing suite: Service examples > Events > when user closes modal by pressing ESC button then modal is closed and should be messages "onHide event has been fired" and "onHidden event has been fired"
4 Modals demo page testing suite: Service examples > Confirm Window > when user clicks on "Open modal" button then modal is opened, it contains two buttons: "Yes" and "No"
5 Modals demo page testing suite: Service examples > Custom css class > when user clicks on the cross button then the modal is closed
6 Modals demo page testing suite: Service examples > Animation option > when user clicks on the cross button then the modal is closed
7 Modals demo page testing suite: Service examples > Esc closing option > when user clicks on "Open modal" button then modal is opened. when user closes modal by click ESC button then modal stays opened
This comment includes only the first 10 test failures. See all 32 failures in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@lexasq lexasq changed the base branch from development to 18-1-2-release-candidate October 18, 2024 08:08
@lexasq lexasq merged commit a795639 into valor-software:18-1-2-release-candidate Oct 18, 2024
9 of 10 checks passed
lexasq added a commit that referenced this pull request Oct 21, 2024
* fix(Typeahead) Typeahead highlight displays <strong> tag when empty spaces added at the end of query and does not escape html tags (#6434)

Co-authored-by: udayk <[email protected]>
Co-authored-by: Alexey Umanskiy <[email protected]>

* fix(typeahead): rolled back changes from UdayAppam and introduced another solution

* update hr.ts (#6447)

change date separation from slashes (/) to dots (.)

Co-authored-by: Dmitriy Shekhovtsov <[email protected]>
Co-authored-by: Alexey Umanskiy <[email protected]>

* fix(chronos): fixed chronos test for updated croatian locale

* fix(bs-dropdown): state provided issue

* fix(daterange-picker): locale change fix

---------

Co-authored-by: UdayAppam <[email protected]>
Co-authored-by: udayk <[email protected]>
Co-authored-by: vrbaaa <[email protected]>
Co-authored-by: Dmitriy Shekhovtsov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants