Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency on redis-cli and redis-server to pass tests #3014

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

avifenesh
Copy link
Collaborator

Trying to work with Fedora which has strict rules about not OSS packages.
The Redis symlink doesn't exist in the distro because of it. When running tests, they fail, since there are many places we depend on the symlinks to exist.

This pr decouple and allow to developer to have just valkey on their system.

This pr also introduce the way to download Valkey using the package managers of the different distros, since those are not explained yet on Valkey sites.

Issue link

This Pull Request is linked to issue #3011

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

…e places where its assume you have redis-cli, and add the difference distros valkey instalation option

Signed-off-by: avifenesh <[email protected]>
…ust package dependencies and improve error handling

Signed-off-by: avifenesh <[email protected]>
@Yury-Fridlyand
Copy link
Collaborator

I propose to split this into 3 PRs, because it contains independent features - doc update, node client fixes and core fixes

@avifenesh
Copy link
Collaborator Author

avifenesh commented Jan 27, 2025

I propose to split this into 3 PRs, because it contains independent features - doc update, node client fixes and core fixes

I'll split into two, doc and tests. The core one is just one change and naming, not sure if it needs a PR for itself.
It actually was a small fix, since I changed to fedora for a bit, discovered that yum already has it and that we are breaking on the valkey installed on fedora because of the strict rules. Then I thought, well, if fedora has it in yum, probably there are others. And apparently all the main ones does so, added to docs.

BTW, on top of mac, Ubuntu and for node, also alpine, glide is compatible with Fedora and Mint, I checked it, and most likely all the CentOS/RHEL family and all the successors of Debian.
Just Arch is in question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
node Node.js wrapper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests fails if having valkey downloaded from package managers of distros with strict OSS rules
2 participants