Go: Implement Bitfield and Bitfield ReadOnly commands #2999
Conversation
Signed-off-by: Niharika Bhavaraju <[email protected]>
Signed-off-by: Niharika Bhavaraju <[email protected]>
Signed-off-by: Niharika Bhavaraju <[email protected]>
Signed-off-by: Niharika Bhavaraju <[email protected]>
| } | ||
|
|
||
| // Subcommands for bitfieldReadOnly. | ||
| type BitFieldROCommands interface { |
There was a problem hiding this comment.
Why are 2 separate interfaces required?
Can we have only one interface named BitFieldCommands?
There was a problem hiding this comment.
Hi @prateek-kumar-improving ,
There are 2 interfaces because one of the interfaces contains dummy()
The dummy() method in BitFieldROCommands helps to distinguish read-only operations from write operations. I followed the convention which is at please refer ZRange as mentioned by @Yury-Fridlyand here
There was a problem hiding this comment.
It allows us to implement for BitFieldGet struct two interfaces: BitFieldROCommands and BitFieldCommands and use it into 2 commands. Having that trick don't duplicate code and don't allow using BitFieldSet in BitFieldRO
| } | ||
|
|
||
| // Subcommands for bitfieldReadOnly. | ||
| type BitFieldROCommands interface { |
There was a problem hiding this comment.
It allows us to implement for BitFieldGet struct two interfaces: BitFieldROCommands and BitFieldCommands and use it into 2 commands. Having that trick don't duplicate code and don't allow using BitFieldSet in BitFieldRO
Signed-off-by: Niharika Bhavaraju <[email protected]>
Go: Implement Bitfield and Bitfield ReadOnly commands