Go: INFO.
#2988
Open
Go: INFO.
#2988
+428
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Failure
7 tasks
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
temporarily deployed
to
AWS_ACTIONS
GitHub Actions
Inactive
jbrinkman
reviewed
Jan 23, 2025
| @@ -46,7 +46,7 @@ func (client *glideClient) CustomCommand(args []string) (interface{}, error) { | |||
| func (client *glideClient) ConfigSet(parameters map[string]string) (string, error) { | |||
| result, err := client.executeCommand(C.ConfigSet, utils.MapToString(parameters)) | |||
| if err != nil { | |||
| return "", err | |||
| return defaultStringResponse, err | |||
There was a problem hiding this comment.
Awesome job on fixing little code quality issues. We should all be looking for opportunities to do this as part of our PRs when we are already making changes to existing code.
| // // `response` stores the command output from a cluster node | ||
| type ClusterValue[T any] struct { | ||
| valueType ValueType | ||
| value Result[T] | ||
| value Result[any] |
There was a problem hiding this comment.
Can you clarify why this change is needed?
There was a problem hiding this comment.
In case when user runs INFO with multi-node route, response is a map (map[string]string), but we return ClusterValue[string]. So we have to store that map there.
valkey-glide/go/api/glide_cluster_client.go
Line 127 in eff4257
Maybe we should follow java approach and have 2 fields inside ClusterValue:
type ClusterValue[T any] struct {
valueType ValueType
singleValue Result[T]
multiValue map[string]T
}WDYT?
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
temporarily deployed
to
AWS_ACTIONS
GitHub Actions
Inactive
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
temporarily deployed
to
AWS_ACTIONS
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INFOcommmandClusterValuewith doc fixIssue link
This Pull Request is linked to issue (URL): #2876
Checklist
Before submitting the PR make sure the following are checked: