Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compute qName once we've filled in the local array. #92

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Compute qName once we've filled in the local array. #92

wants to merge 1 commit into from

Conversation

emilio
Copy link
Contributor

@emilio emilio commented Oct 18, 2024

Since it depends on it.

Fixes #91

@emilio
Copy link
Contributor Author

emilio commented Oct 18, 2024

@sideshowbarker can you confirm this fixes the issue you're seeing?

@emilio
Copy link
Contributor Author

emilio commented Oct 18, 2024

Build failures seem unrelated

@emilio
Copy link
Contributor Author

emilio commented Oct 18, 2024

cc @hsivonen

@emilio emilio mentioned this pull request Oct 18, 2024
Closed
@sideshowbarker
Copy link
Contributor

@sideshowbarker can you confirm this fixes the issue you're seeing?

Yeah, it does (and thanks much)

sideshowbarker
sideshowbarker approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@sideshowbarker sideshowbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will wait to merge until @hsivonen has also reviewed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sideshowbarker sideshowbarker sideshowbarker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilio @sideshowbarker