Add auto_ptr & std_map keys() method on Javascript #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadz
reviewed
Sep 17, 2019
| @@ -61,6 +61,13 @@ namespace std { | |||
| std::map< K, T, C >::iterator i = self->find(key); | |||
| return i != self->end(); | |||
| } | |||
| std::vector<K> keys() { | |||
| std::vector<K> keys; | |||
There was a problem hiding this comment.
I'd call keys.reserve(self->size()) here, it could be a useful optimization for bigger maps.
|
I've created PRs for map::keys() and another one for auto_ptr in the main SWIG repo. Let's see if the CI builds pass for them before merging it into our version. |
ojwb
pushed a commit
that referenced
this pull request
Mar 17, 2024
Update octrun.swg to work with Octave v8.1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swig now generate a new method to access to the keys of st::map(s) on the javascript wrapping.
Swig with javascript now support getting values from an std::auto_ptr. Even if std::auto_ptr it less and less used, there still exist code that use them.