Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update zxlib #5

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Flex icon

c209e9f
Select commit
Loading
Failed to load commit list.
Open

Update zxlib #5

Flex icon
c209e9f
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL succeeded Oct 28, 2024 in 3s

15 new alerts

New alerts in code changed by this pull request

  • 3 warnings
  • 12 notes

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 64 in deps/ledger-zxlib/app/ui/view_internal.h

See this annotation in the file changed.

Code scanning / CodeQL

Unused static variable Note

Static variable review_key is never read.

Check notice on line 65 in deps/ledger-zxlib/app/ui/view_internal.h

See this annotation in the file changed.

Code scanning / CodeQL

Unused static variable Note

Static variable review_txvalue is never read.

Check notice on line 66 in deps/ledger-zxlib/app/ui/view_internal.h

See this annotation in the file changed.

Code scanning / CodeQL

Unused static variable Note

Static variable review_addrvalue is never read.

Check notice on line 67 in deps/ledger-zxlib/app/ui/view_internal.h

See this annotation in the file changed.

Code scanning / CodeQL

Unused static variable Note

Static variable review_keyconfig is never read.

Check notice on line 68 in deps/ledger-zxlib/app/ui/view_internal.h

See this annotation in the file changed.

Code scanning / CodeQL

Unused static variable Note

Static variable review_configvalue is never read.

Check notice on line 76 in deps/ledger-zxlib/app/ui/view_internal.h

See this annotation in the file changed.

Code scanning / CodeQL

Unused static variable Note

Static variable review_msgKey is never read.

Check notice on line 77 in deps/ledger-zxlib/app/ui/view_internal.h

See this annotation in the file changed.

Code scanning / CodeQL

Unused static variable Note

Static variable review_msgValue is never read.

Check notice on line 79 in deps/ledger-zxlib/app/ui/view_internal.h

See this annotation in the file changed.

Code scanning / CodeQL

Unused static variable Note

Static variable shortcut_key is never read.

Check notice on line 80 in deps/ledger-zxlib/app/ui/view_internal.h

See this annotation in the file changed.

Code scanning / CodeQL

Unused static variable Note

Static variable shortcut_value is never read.

Check notice on line 94 in deps/ledger-zxlib/app/ui/view_internal.h

See this annotation in the file changed.

Code scanning / CodeQL

FIXME comment Note

FIXME comment: Wait to be fixed on SDK:

Check warning on line 88 in deps/ledger-zxlib/app/ui/view_nano.c

See this annotation in the file changed.

Code scanning / CodeQL

Comparison result is always the same Warning

Comparison is always false because extraScreens <= 0.

Check warning on line 111 in deps/ledger-zxlib/app/ui/view_nano.c

See this annotation in the file changed.

Code scanning / CodeQL

Comparison result is always the same Warning

Comparison is always false because extraScreens <= 0.

Check notice on line 190 in deps/ledger-zxlib/app/ui/view_x.c

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Check warning on line 701 in deps/ledger-zxlib/src/timeutils.c

See this annotation in the file changed.

Code scanning / CodeQL

Year field changed using an arithmetic operation without checking for leap year Warning

Field
tm_year
Loading
on variable
date
Loading
has been modified, but no appropriate check for LeapYear was found.

Check notice on line 301 in deps/ledger-zxlib/app/ui/view_nbgl.c

See this annotation in the file changed.

Code scanning / CodeQL

Long switch case Note

Switch has at least one case that is too long:
0 (35 lines)
Loading
.