feat: add drag&drop support to vaadin-chart #8488
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Until now, the
vaadin-chart
component did not support drag&drop at all.This PR brings support for drag and drop:
vaadin-chart
: dragStart, drag and drop -> the code is the same as for any other chart point eventThe only significant change is in the
__createEventListeners
method: I found during testing, that the data of thecustomEvent
are not correct in case ofdragStart
. Highcharts firesdragStart
with a different content of theevent
object:event.type
is missing, and theevent
object itself is actually the originalmousedown
event object.However, Highcharts passes the
point
that is being dragged as athis
of the event handler (it does this for every event type... even for the series events - in that casethis
refers to the series). Therefore the change in the__createEventListeners
-> the arrow function was changed to a regular function, so differentthis
can be passed to it. We then setthis
tocustomEvent.detail.point
as the point that is being dragged.I added a test that simulates what happens when you click the chart and you are over the draggable point.
Part of vaadin/flow-components#4731
Type of change
Checklist
Additional for
Feature
type of change