Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two java compiler warnings #867

Merged
merged 2 commits into from
May 24, 2024
Merged

Fix two java compiler warnings #867

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8b67e0
Fix overrides warning
david-hall May 24, 2024
51ba8eb
Fix fallthrough warning
david-hall May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions core/src/main/java/com/vzome/core/algebra/PentagonField.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,9 @@ public void interpretScript( String script, String language, Point offset, Symme

case "zomod":
program = parseZomodScript( script );
// TODO: reenable support for zomod ???
errors .parseError( 0, 0, "zomod is not currently a supported script language." );
break;

default:
errors .parseError( 0, 0, language+" is not a supported script language." );
Expand Down
9 changes: 8 additions & 1 deletion desktop/src/main/java/com/vzome/desktop/controller/PreviewStrut.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,14 @@ public boolean equals(Object obj) {
return false;
}

private void setZone( Axis zone )
@Override
public int hashCode() {
// Since overriding equals is required for JSweet as described above, this method simply avoids the warning:
// [overrides] Class PreviewStrut overrides equals, but neither it nor any superclass overrides hashCode method.
return super.hashCode();
}

private void setZone( Axis zone )
{
this.zone = zone;
}
Expand Down
Loading