Skip to content

Commit

Permalink
Merge pull request #958 from vorth/color-bom-fix
Browse files Browse the repository at this point in the history
Fixed case sensitivity in BOM color tests
  • Loading branch information
vorth authored Jan 17, 2025
2 parents 3663ab7 + 78e5299 commit c203045
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion online/serve/app/test/cases/zometool-model/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ <h1>Zometool Model Demo</h1>
<div class="zometool-model-difficulty" data-difficulty="medium">
</div>

<zometool-instructions src="https://raw.githubusercontent.com/vorth/vzome-sharing/main/2024/09/25/23-37-59-596Z-standard-colors-and-lengths-instructions/standard-colors-and-lengths-instructions.vZome">
<!-- <zometool-instructions src="https://raw.githubusercontent.com/vorth/vzome-sharing/main/2024/09/25/23-37-59-596Z-standard-colors-and-lengths-instructions/standard-colors-and-lengths-instructions.vZome"> -->
<zometool-instructions src="https://raw.githubusercontent.com/lucosmic/vzome-sharing/main/2025/01/12/01-29-12-PRJ-DNA-kit/PRJ-DNA-kit.vZome">
<!-- <zometool-instructions src="https://raw.githubusercontent.com/vorth/vzome-sharing/main/2024/09/01/21-01-21-623Z-standard-colors-and-lengths/standard-colors-and-lengths.vZome"> -->
<!-- <zometool-instructions src="https://raw.githubusercontent.com/vorth/vzome-sharing/main/2024/09/24/02-42-34-519Z-hyperdo-steps-correct-scale/hyperdo-steps-correct-scale.vZome"> -->
</zometool-instructions>
Expand Down
2 changes: 1 addition & 1 deletion online/src/worker/legacy/partslist.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export const assemblePartsList = ( shapes, colors ) =>
if ( !name && !orbit ) continue;
const row = name || `${orbit}:${length}`
for (const { color } of instances) {
const match = Object.entries( colors ) .filter( ([ name, value ]) => value === color );
const match = Object.entries( colors ) .filter( ([ name, value ]) => value === color.toLowerCase() );
const colorBin = match[0]? match[0][ 0 ] : 'other';
if ( ! bom[ row ] )
bom[ row ] = {};
Expand Down

0 comments on commit c203045

Please sign in to comment.