Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typos and changed the Sylow proof #262

Merged
merged 1 commit into from
Jan 12, 2025
Merged

Conversation

jfab20
Copy link
Contributor

@jfab20 jfab20 commented Jan 9, 2025

  • Corrected a typo, because $G$ acts on $X$, which is a set of subsets of G, and you used the letter $X$ for an element of $X$. I changed it to $g \cdot S = \{ g s \mid s \in S \}$.
  • Second of all, you don't actually need step 1 in step 2. You are just proving the statement "given some Sylow $p$-subgroup and any $p$-subgroup, this happens ...".
  • The existence of $P$ is actually necessary for step $3$, because you have to take some specific $P$ and use the orbit stabilizer theorem with it, so I moved the phrase that remarks the usefulness of step 1 to step 3 and removed it from step 2.

Copy link

github-actions bot commented Jan 9, 2025

Hey there and thank you for opening this pull request! 👋

We require pull request titles to follow the Conventional Commits specification. This comment indicates a fix is needed to repair this.

How do I fix this?

For most of you, this means that the PR title should say either

  • fix: [short description here] (if you are fixing an issue)
  • feat: [short description here] (if you are introducing a new feature)

depending on whether you are fixing an issue or doing something new, respectively. But some other types might be suitable too, see the list below:

  • build: build related
  • ci: work related to CI
  • chore: updating deps, etc.
  • docs: documentation changes
  • drop: deleting stuff or removing a feature
  • edit: minor changes that don't constitute a new feature
  • perf: performance improvements
  • polish: copy editing or cleanup that doesn't affect functionality
  • refactor: major rewriting or restructuring that doesn't fix bugs or affect functionality
  • revert: revert commits
  • style: code style changes
  • test: unit testing, etc.

Please adjust the proposed title and this check will resolve automatically!

Detailed error message

No release type found in pull request title "fix typos and changed the Sylow proof". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:

  • fix
  • feat
  • build
  • ci
  • chore
  • docs
  • drop
  • edit
  • perf
  • polish
  • refactor
  • revert
  • style
  • test

@jfab20 jfab20 changed the title Fix: Typos and changes to the Sylow proof fix typos and changed the Sylow proof Jan 9, 2025
@vEnhance vEnhance changed the title fix typos and changed the Sylow proof fix: typos and changed the Sylow proof Jan 10, 2025
@vEnhance
Copy link
Owner

thank you!

@vEnhance vEnhance merged commit e6add8c into vEnhance:main Jan 12, 2025
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants