Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check SELinux labels on container volumes #9708

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Bischoff
Copy link
Contributor

@Bischoff Bischoff commented Jan 30, 2025

What does this PR change?

This PR officializes Vladimir's test for SELinux problems.

Feel free to object this PR. It adds 5 minutes to the sanity checks!

Another option could be to run it at the end of the testsuite, at same time we check the logs. The idea to do it at the beginning is that we can spare ourselves a run if SELinux is going to block us.

Links

Port(s):

  • 5.0:

Changelogs

  • No changelog needed

Copy link
Contributor

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/9708/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/9708/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

@Bischoff Bischoff requested a review from nadvornik January 30, 2025 14:48
nadvornik
nadvornik previously approved these changes Jan 30, 2025
Copy link
Contributor

@nadvornik nadvornik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bischoff Bischoff force-pushed the selinux-sanity-check branch 3 times, most recently from 2c699d9 to 58cee2a Compare January 30, 2025 18:21
@Bischoff Bischoff force-pushed the selinux-sanity-check branch from 58cee2a to 4b50524 Compare January 30, 2025 18:21
@Bischoff Bischoff requested a review from srbarrios January 30, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants