Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve task arena test coverage #725

Merged

Conversation

alexey-katranov
Copy link
Contributor

Signed-off-by: Alexei Katranov [email protected]

Description

#566 added two functions into task_arena class that are not covered with tests:

tbb::detail::d1::task_arena::initialize(d1::attach)
tbb::detail::d1::task_arena::task_arena(d1::attach)

Cover these functions with tests.

  • - git commit message contains appropriate signed-off-by string (see CONTRIBUTING.md for details)

Type of change

Choose one or multiple, leave empty if none of the other choices apply

Add respective label(s) to PR if you have permissions

  • bug fix - change which fixes an issue
  • new feature - change which adds functionality
  • tests - change in tests
  • infrastructure - change in infrastructure and CI
  • documentation - documentation update

Tests

  • added - required for new features and for some bug fixes
  • not needed

Documentation

  • updated in # - add PR number
  • needs to be updated
  • not needed

Breaks backward compatibility

  • Yes
  • No
  • Unknown

Notify the following users

@anton-potapov

Other information

Signed-off-by: Alexei Katranov <[email protected]>
Copy link
Contributor

@anton-potapov anton-potapov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexey-katranov alexey-katranov merged commit 1eaccf7 into master Jan 13, 2022
@alexey-katranov alexey-katranov deleted the dev/alexey.katranov/improve-task-arena-coverage branch January 13, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants