Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DFT] Introduce a cuFFT backend for the DFT interface #278

Closed
wants to merge 6 commits into from
Closed

[DFT] Introduce a cuFFT backend for the DFT interface #278

wants to merge 6 commits into from

Conversation

FMarno
Copy link
Contributor

@FMarno FMarno commented Feb 10, 2023

Description

This builds on #259 to introduce a cuFFT backend. tests are included in #261.
Currently this only supports single precision, in-place, complex-to-complex dfts. A another PR will follow soon to implement as much of the interface as possible.

Checklist

All Submissions

  • Do all unit tests pass locally? Attach a log.
  • [x ] Have you formatted the code using clang-format?

New features

  • [x ] Have you provided motivation for adding a new feature?
  • Have you added relevant tests?

@FMarno FMarno changed the title Cufft backend pr Introduce a cuFFT backend for the DFT interface Feb 10, 2023
hjabird
hjabird reviewed Feb 10, 2023
View reviewed changes
Copy link
Contributor

@hjabird hjabird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

examples/dft/run_time_dispatching/real_fwd_usm.cpp Outdated Show resolved Hide resolved
include/oneapi/mkl/dft/detail/descriptor_impl.hpp Outdated Show resolved Hide resolved
src/dft/backends/cufft/commit.cpp Show resolved Hide resolved
src/dft/backends/cufft/commit.cpp Outdated Show resolved Hide resolved
src/dft/backends/cufft/forward.cpp Outdated Show resolved Hide resolved
t4c1
t4c1 reviewed Feb 13, 2023
View reviewed changes
src/dft/backends/cufft/backward.cpp Outdated Show resolved Hide resolved
src/dft/backends/cufft/commit.cpp Outdated Show resolved Hide resolved
src/dft/backends/cufft/forward.cpp Outdated Show resolved Hide resolved
@FMarno FMarno changed the title Introduce a cuFFT backend for the DFT interface [DFT] Introduce a cuFFT backend for the DFT interface Feb 22, 2023
@Rbiessy Rbiessy mentioned this pull request Feb 22, 2023
Merged
4 tasks
@FMarno FMarno mentioned this pull request Mar 1, 2023
Merged
2 tasks
@FMarno FMarno force-pushed the cufft_backend_pr branch from 25edc41 to f187589 Compare March 9, 2023 11:05
@FMarno
Copy link
Contributor Author

FMarno commented Mar 9, 2023

I believe it will be easier for the maintainers to only review #284, so I am closing this PR in favour of adding the whole backend at once.

@FMarno FMarno closed this Mar 9, 2023
@FMarno FMarno deleted the cufft_backend_pr branch March 9, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rbiessy Rbiessy Rbiessy approved these changes

@hjabird hjabird hjabird approved these changes

@t4c1 t4c1 t4c1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FMarno @t4c1 @hjabird @Rbiessy