Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DFT] Multi-Dimension Many-Batch DFT tests #275

Merged
merged 7 commits into from
Mar 28, 2023
Merged

[DFT] Multi-Dimension Many-Batch DFT tests #275

merged 7 commits into from
Mar 28, 2023

Conversation

FMarno
Copy link
Contributor

@FMarno FMarno commented Feb 2, 2023

Description

This builds on #261 to introduce tests for multi-dimensional DFTs and batched DFTs.

Checklist

All Submissions

  • Do all unit tests pass locally? Attach a log.
  • Have you formatted the code using clang-format?

@FMarno FMarno force-pushed the multi_d_many_batch_pr branch 3 times, most recently from 567f0a5 to 1c29867 Compare February 15, 2023 17:09
@FMarno FMarno changed the title Multi-Dimension Many-Batch DFT tests [DFT] Multi-Dimension Many-Batch DFT tests Feb 22, 2023
Rbiessy
Rbiessy approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@Rbiessy Rbiessy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, LGTM

@Rbiessy
Copy link
Contributor

Rbiessy commented Feb 28, 2023

Tests log: log_mklgpu.txt

@FMarno
Copy link
Contributor Author

FMarno commented Mar 2, 2023

When testing #284 with these new tests I found an off by one error. This has been updated in 348867b

@Rbiessy
Copy link
Contributor

Rbiessy commented Mar 2, 2023

I can confirm the tests are still passing: log_mklgpu.txt

@anantsrivastava30 anantsrivastava30 mentioned this pull request Mar 6, 2023
Merged
11 tasks
@FMarno FMarno force-pushed the multi_d_many_batch_pr branch from 348867b to a5dbccc Compare March 9, 2023 11:47
@FMarno FMarno mentioned this pull request Mar 13, 2023
Merged
2 tasks
raphael-egan
raphael-egan reviewed Mar 15, 2023
View reviewed changes
tests/unit_tests/dft/include/reference_dft.hpp Outdated Show resolved Hide resolved
tests/unit_tests/dft/include/reference_dft.hpp Outdated Show resolved Hide resolved
tests/unit_tests/dft/include/reference_dft.hpp Outdated Show resolved Hide resolved
tests/unit_tests/dft/include/reference_dft.hpp Outdated Show resolved Hide resolved
tests/unit_tests/dft/include/reference_dft.hpp Show resolved Hide resolved
tests/unit_tests/dft/include/compute_out_of_place.hpp Outdated Show resolved Hide resolved
tests/unit_tests/dft/include/compute_out_of_place.hpp Outdated Show resolved Hide resolved
tests/unit_tests/dft/include/compute_out_of_place.hpp Outdated Show resolved Hide resolved
tests/unit_tests/dft/include/compute_inplace.hpp Outdated Show resolved Hide resolved
tests/unit_tests/dft/include/compute_out_of_place.hpp Outdated Show resolved Hide resolved
raphael-egan
raphael-egan approved these changes Mar 21, 2023
View reviewed changes
Copy link

@raphael-egan raphael-egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work!

@FMarno FMarno force-pushed the multi_d_many_batch_pr branch from 14bfce1 to 385c41f Compare March 27, 2023 15:59
@lhuot lhuot merged commit e3fe270 into uxlfoundation:develop Mar 28, 2023
@FMarno FMarno deleted the multi_d_many_batch_pr branch March 28, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphael-egan raphael-egan raphael-egan approved these changes

@lhuot lhuot lhuot approved these changes

@Rbiessy Rbiessy Rbiessy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@FMarno @Rbiessy @lhuot @raphael-egan @t4c1