Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix memory leak #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix memory leak #8

wants to merge 1 commit into from

Conversation

wntiv-main
Copy link

No description provided.

@wntiv-main
Copy link
Author

should fixes #7
sorry i dont fully understand the full intent of your code, but my (albeit short) testing seems to indicate this fixes the issue and is still functional. i'm uncertain whether deleting from the songs "cache" is needed, or a good idea - as far as i can see, there are so many songs at this point that caching them all isnt neccesarily a good idea. wouldnt browser cache also cover this anyways? in any case, feel free to adapt this pr as nesseccary.

thanks for all your work putting this together :3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wntiv-main