add new theme classic-dark #463
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rpetit3 I like the idea of keeping the original dark theme around for folks who don't want to adopt GitHub's official dark theme. I'll revisit this PR once Primer lands primer/css#1131. What do you think of Classic Dark for the theme name? |
|
Classic Dark works perfectly! I'll update the PR |
xypnox
approved these changes
Jun 25, 2021
|
Hi @jdanyow If you have a moment, would love to get your thoughts. Thank you! |
|
@jdanyow - Please me know if anything is needed on my end. |
|
@jdanyow I think I'm going to go ahead and abandon this PR. Utterances is great cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Here's a new theme that is based off 'github-dark' to match Github's current Dark Mode.
We had a brief discussion (#462) and I realize the "github-dark" theme will be updated when Primer is updated. This made me think it might be useful to create a separate theme, so that changes to Primer or GitHub's Dark Mode won't affect the theme.
I named it dark-mood, and I'm not attached to it, so if you want to rename go for it!
Please let me know if anything else is needed.
Thank you!
Here's a screenshots, from my local build:
