Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark purple theme for utterances #441

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

VatsaDev
Copy link

Hi its my first time on an open source project and I made a dark purple theme for utterances, hope you add it!

-vatsadev

@VatsaDev
Copy link
Author

I also added my site to the utterances list

@VatsaDev
Copy link
Author

hello????

Copy link
Contributor

@zsdycs zsdycs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi~ @VatsaDev

After reading this "PR", I have the following thoughts:

  1. The "configuration-component.ts" file has not been modified. You should add options for this theme in <select id="theme" ……>……</select>.
  2. What is colors.txt used for?
  3. The "button.scss" code is not properly indented and should be formatted.
  4. The title of this "PR" is "Dark purple theme for utterances", and the SITES.md file should not be modified.

good luck!

@zsdycs
Copy link
Contributor

zsdycs commented Jun 9, 2021

In addition, I did not run this code, if the renderings are attached, it will make this "PR" icing on the cake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants