Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read and parse configuration files. Fixes #41. #42

Merged
merged 22 commits into from
Oct 16, 2024
Merged

Conversation

utoni
Copy link
Owner

@utoni utoni commented Sep 26, 2024

No description provided.

@utoni utoni force-pushed the add/config-file-support branch 6 times, most recently from 3a2e831 to 8de317b Compare September 30, 2024 11:46
@utoni utoni marked this pull request as ready for review October 8, 2024 09:51
utils.c Outdated
return -ENOENT;
}

file = fopen(config_file, "r");

Check failure

Code scanning / SonarCloud

Accessing files should not introduce TOCTOU vulnerabilities

<!--SONAR_ISSUE_KEY:AZJzSdZmwHCaoenFJLog-->Remove this TOCTOU race condition window when accessing files <p>See more on <a href="https://sonarcloud.io/project/issues?id=lnslbrty_nDPId&issues=AZJzSdZmwHCaoenFJLog&open=AZJzSdZmwHCaoenFJLog&branch=add%2Fconfig-file-support">SonarCloud</a></p>
Copy link

gitguardian bot commented Oct 15, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

 * added additional missing config options
 * added some documentation in the config file

Signed-off-by: Toni Uhlig <[email protected]>
 * added WARN_UNUSED

Signed-off-by: Toni Uhlig <[email protected]>
Signed-off-by: Toni Uhlig <[email protected]>
 * adjusted systemd to make use of those

Signed-off-by: Toni Uhlig <[email protected]>
 * removed unsafe and not necessary `strlen()`s

Signed-off-by: Toni Uhlig <[email protected]>
 * makes lots sense for nDPIsrvd and some examples
 * added debian dpkg scripts for user mgmt
 * nDPIsrvd: set different groups for collector/distributor UNIX socket

Signed-off-by: Toni Uhlig <[email protected]>
Signed-off-by: Toni Uhlig <[email protected]>
@utoni utoni merged commit efed6f1 into main Oct 16, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant