Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add close_file method to Module API #85

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

axelboc
Copy link
Collaborator

@axelboc axelboc commented Sep 5, 2024

I use the Module API directly in H5Web, because of the web worker, and this will remove the only remaining ccall invocation.

@axelboc axelboc force-pushed the add-close branch 2 times, most recently from 8c52fbb to fef7f74 Compare September 5, 2024 08:44
@axelboc axelboc changed the title Add close method to Module API Add close_file method to Module API Sep 5, 2024
@axelboc
Copy link
Collaborator Author

axelboc commented Sep 5, 2024

Overconfident as always... I got an obscure error when I named the function close. Renaming it to close_file fixed it, so I assume close conflicted with an existing function. The tests now pass and the new close_file method works as expected in H5Web.

@axelboc
Copy link
Collaborator Author

axelboc commented Sep 6, 2024

I've rebased to keep the commit graph clean.

@bmaranville bmaranville merged commit 437b5c6 into usnistgov:main Sep 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants