feat: new common job form #683
Merged
+499
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
There was a problem hiding this comment.
This properly implements the changes in the issue.
One thing I noticed is that if there is no associated entrypoint or queue, the drop down is correctly empty, but it might not be clear to the user why this is the case or what to do to correct it. We should consider including an inline message or maybe even a "quick add" dialog to make these associations.
This commit makes the following changes to the Job creation form in the frontend: - Jobs can now be created through the all-jobs page and the experiment -> job page. - Entrypoint dropdown will be greyed out until experiment is selected, and will only show entrypoints that are linked to the selected experiment - Queue dropdown will be greyed out until entrypoint is selected, and will only show queues that are linked to the selected entrypoint - A message with link that opens a dialog box to update experiment/entrypoint associations is added under the Entrypoint dropdown - A message with link that opens a dialog box to update entrypoint/queue associations is added under the Queue dropdown - Returning to an unsaved form should give you the option to load previous values
keithmanville
force-pushed
the
job-form
branch
from
cc2bd85 to
c404551
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #620