fix: fix issue in modifying plugins associated with an entrypoint #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithmanville
force-pushed
the
fix-modify-entrypoint-plugins
branch
2 times, most recently
from
988ffa9
to
d8ca8fd
Compare
This commit fixes an issue when appending or deleting a plugin from an entrypoint. The services were re-using EntrypointPluginFile and EntrypointParameter ORM objects when creating new Entrypoint snapshots. This led to consistency errors in the database. The service implementations were corrected to construct new ORM objects to attach to the new Entrypoint snapshot
jkglasbrenner
force-pushed
the
fix-modify-entrypoint-plugins
branch
from
d8ca8fd
to
3233d9c
Compare
jkglasbrenner
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue when appending or deleting a plugin from an entrypoint. The services were re-using EntrypointPluginFile and EntrypointParameter ORM objects when creating new Entrypoint snapshots. This led to consistency errors in the database. The service implementations were corrected to construct new ORM objects to attach to the new Entrypoint snapshot