Refactor jobs restapi to remove wtforms

[alexb1200]

Addresses issue #313, removes the wtforms dependency, refactors the controller to accept the job form, and changes _client.py and client.py to reflect those changes. Makes minimal changes to the jobs unit tests to reflect those updates.

[jkglasbrenner]

#328 has been merged. I just squashed and rebased this branch/pull request to bring this in sync with the latest changes in dev.

[jkglasbrenner]

While doing a code review, I found that the Swagger documentation wasn't coming out right, even after using load_only and dump_only on the Marshmallow Schema. The issue is that form_schema= argument for the @accepts decorator is processed differently, and basically it ignores load_only and dump_only when generating the Swagger Docs.

I'm working on a way to fix this without needing to patch the flask_accepts package. Somewhat related to the above, I'm also fixing things so that you can access the form submitted to POST using request.parsed_form and so that everything can be handled with just JobSchema so that we can delete JobSubmitSchema. When I get these worked out, I'll push the update to this branch.

Finally, I want to verify that the file upload works not just in the unit tests but also when I build and run the full deployment.

[jkglasbrenner]

I've implemented the changes so that we can use form_schema= with a Marshmallow Schema that makes use of dump_only and load_only, and allows us to generate the correct Swagger docs. Here's what the decorators on the post function look like now:

dioptra/src/dioptra/restapi/job/controller.py

Lines 72 to 78 in 6d12f9c

	@api.expect(
	as_api_parser(
	api,
	as_parameters_schema_list(JobSchema, operation="load", location="form"),
	)
	)
	@accepts(form_schema=JobSchema, api=api)

The new part is the as_parameters_schema_list function, which takes the Marshmallow schema and converts it to the format needed in the as_api_parser function. The as_parameters_schema_list respects the dump_only and load_only settings, so the documentation for the POST endpoint now comes out correct:

Also, just to document a "gotcha" with the difference between how the requests package works and the Flask test client works:

I had to go back and restore the files= argument in the requests.post method used in the Dioptra client, as it's the only way to specify a file for uploading:

dioptra/src/dioptra/client/_client.py

Lines 686 to 691 in 6d12f9c

	job_files = {"workflow": (workflows_file.name, f)}
	response = requests.post(
	self.job_endpoint,
	data=job_form,
	files=job_files,
	)

It is different from the Flask test client, which doesn't use the files= argument:

dioptra/tests/unit/restapi/job/test_controller.py

Lines 151 to 157 in 6d12f9c

	with app.test_client() as client:
	response: Dict[str, Any] = client.post(
	f"/api/{JOB_BASE_ROUTE}/",
	content_type="multipart/form-data",
	data=job_form_request,
	follow_redirects=True,
	).get_json()

[jkglasbrenner]

As long as the GitHub Actions tests all pass, this is ready to merge.

In terms of merge order, I'm going to review and merge the fix in #342 first to dev, since it also touches the Job endpoint. Then I'm going to resolve any conflicts that introduces in this branch, and once that's handled, merge this in.

[jkglasbrenner]

Rebased this branch after merging #342 to dev, all unit tests and code quality checks passed. Looks good to me for a merge.