-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formalize the Dioptra Client #220
Conversation
Preparing to review: I split off the changes under the |
8109ec9
to
a7bb7ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of this review is focused on the whitespace structure of the docstrings themselves. Basically, although there are 64 comments, a lot of them are duplicative and are just there to flag the places I noticed something to be addressed.
The change requests are mainly about how to update the docstrings so they conform with the 88 characters or less per line style rule and ensuring there are 4 spaces per indentation level. There's also suggestions on how to structure the whitespace for the responses in the example blocks so they're following a consistent style everywhere. The rest are just minor things like deleting extra lines of whitespace.
013e985
to
4745ab8
Compare
This update formalizes the `DioptraClient` class in examples/scripts/client.py by adding it to the dioptra package and adding documentation for it.
4745ab8
to
3505f6f
Compare
Towards Resolving #210