Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[USH-1706] Onboarding guide stops progressing after 'filtering' modal #1508

Open
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

MMwandigha
Copy link
Contributor

Issue Description:
The onboarding flow stops progressing after displaying the 'Filtering' guide. Following this, a persistent dark overlay appears, preventing any further interaction with the system. The overlay cannot be dismissed unless the user refreshes the page to regain access.

Approach;
I uncommented the code that delays the highlight update using setTimeout to ensure the DOM is fully rendered before proceeding. This snippet initially checks if the step is dynamic eg. 'sorting' requires the feed view to display so as to highlight the button

Copy link

linear bot commented Jan 7, 2025

@MMwandigha MMwandigha requested a review from Angamanga January 8, 2025 11:43
Copy link
Contributor

@Angamanga Angamanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works fine! I did some digging in the git-history to try to understand this change, at the same time as this was removed, the code on the lines 100-107 were added. Things has changed along the way and now they are never called, that is probably why this breaks now. You can remove that part (100-107) and then we are good to go 👍

@MMwandigha
Copy link
Contributor Author

MMwandigha commented Jan 8, 2025

This works fine! I did some digging in the git-history to try to understand this change, at the same time as this was removed, the code on the lines 100-107 were added. Things has changed along the way and now they are never called, that is probably why this breaks now. You can remove that part (100-107) and then we are good to go 👍

Ah I see. I also have just noticed the functionalities are (if not) the same. Noted, I will remove those lines

Copy link
Contributor

@Angamanga Angamanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants