-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Pa11y Automated Accessibility Testing #1138
base: development
Are you sure you want to change the base?
Integrate Pa11y Automated Accessibility Testing #1138
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kivuvarosekivuvan nice work on integrating pally.
I have left some comments for here on this PR, and some in slack.
@@ -34,7 +34,6 @@ | |||
"@supy-io/ngx-intercom": "^14.2.12", | |||
"@swimlane/ngx-charts": "^20.1.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kivuvarosekivuvan for the package-lock.json
file, let's approach it like this to resolve conflicts. And also because the package-lock.json shouldn't even be showing up here since it's generated (maintainers will do that work of generating it for contributors).
Restore the package-lock.json
to original, the add and commit only the package-lock file, then push.
If your package-lock file changes again, just ensure not to add, commit and push it along with the other the files you have worked on.
@kivuvarosekivuvan This is really, really useful! Do you think there is other useful commands we could use? Maybe a custom-command where one can paste in the url to test. Like |
@Angamanga Sure, I can definitively try this |
Implemented a new custom command that allows users to test a specified URL
bd33e69
to
ba03d4f
Compare
Description
NOTE: This is something that I am still trying to figure out, things like testing for a modal/components we have because at the moment this can test the page individually with the different commands provided to test each page, however I'm open to receive any comment
Key Changes
npm install pa11y --save-dev.
"test:feed": "pa11y --config pa11y.config.js 'http://localhost:4200/feed'",
"test:activity": "pa11y --config pa11y.config.js 'http://localhost:4200/activity'",
"test:general": "pa11y --config pa11y.config.js 'http://localhost:4200/settings/general'",)
Screenshot