Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: publish-sdk #146

Merged
merged 1 commit into from
Oct 23, 2024
Merged

chore: publish-sdk #146

merged 1 commit into from
Oct 23, 2024

Conversation

seeratawan01
Copy link
Member

@seeratawan01 seeratawan01 commented Oct 23, 2024

PR Type

enhancement


Description

  • Enhanced the continuous deployment workflow by including package.json and pnpm-workspace.yaml in the artifacts path.
  • Cleaned up unnecessary whitespace in the publish-sdk job for better readability.

Changes walkthrough 📝

Relevant files
Enhancement
cd-develop.yml
Update artifacts path and clean up whitespace in CD workflow

.github/workflows/cd-develop.yml

  • Added package.json and pnpm-workspace.yaml to the artifacts path.
  • Removed extra whitespace in the publish-sdk job.
  • +3/-1     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @seeratawan01 seeratawan01 merged commit 8ac1a71 into develop Oct 23, 2024
    @github-actions github-actions bot added the enhancement New feature or request label Oct 23, 2024
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    🏅 Score: 92
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Configuration Update
    Ensure that the addition of package.json and pnpm-workspace.yaml to the artifacts path is correctly aligned with the project's deployment and artifact management strategy.

    Code feedback:
    relevant file.github/workflows/cd-develop.yml
    suggestion      

    Consider adding a comment above the newly added lines explaining why package.json and pnpm-workspace.yaml are included in the artifacts path. This will help maintain clarity for future modifications. [important]

    relevant linepackage.json

    relevant file.github/workflows/cd-develop.yml
    suggestion      

    Verify the retention-days setting for the new artifacts to ensure they align with the project's storage policies and cost management. [medium]

    relevant linepnpm-workspace.yaml

    Copy link

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    Possible issue
    Ensure correct YAML syntax by verifying file paths under the path key

    Ensure that the package.json and pnpm-workspace.yaml files are correctly placed
    under the path key to avoid YAML syntax errors.

    .github/workflows/cd-develop.yml [104-105]

     path: |
       packages/*/dist/**
       packages/*/package.json
       packages/*/README.md
    -  package.json
    -  pnpm-workspace.yaml
    +  ./package.json
    +  ./pnpm-workspace.yaml
    Suggestion importance[1-10]: 7

    Why: The suggestion to prefix package.json and pnpm-workspace.yaml with ./ improves clarity and consistency in file paths, potentially preventing path resolution issues. However, it does not address a critical bug, so its impact is moderate.

    7

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    enhancement New feature or request
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant