-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Share tags #4198
Open
RoccoSmit
wants to merge
12
commits into
usememos:main
Choose a base branch
from
RoccoSmit:share-tags
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Share tags #4198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added server side validation for sharing tags - Allowed shared tag editing - Allowed shared tag deleting
- added validation taht use needs to be logged in for tag share
Merged latest master into PR @boojack, @johnnyjoygh, is this feature under consideration to be added? If it is, I'll keep it up to date with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #3103, #3985 and #4178 users are currently not able to share tag across
workspaces
.This PR is to allow for
workspace
andpublic
tags to be shared.Design decision:
ListMemos
endpoint and setting the data that is needed via therequest.View
flag similar to what is done with memos vs metadata. I could not piggyback off the metadata flow as the metadata numbers would include other user's memos as wellShareTags
property on thefilter
object and adding extra SQL to go along with it.rename
andedit
other user's tags. This will only take effect on memos that are marked asworkspace
orpublic
share tags
setting. I can do that separately if the PR gets approved.Experience:
in the below examples there are 2 users (
User-1
andUser-2
). They both have 1private
,workspace
andpublic
memo with an identifying tag name in each. each user also has aworkspace
levellink
,todo
andcode
memo.Settings screen
Shared tags showing in the tag panel and metadata numbers are for user only
User only has access to their own private tags
User has access to shared tags
The explore page still functions as expected logged in and out
logged in
logged out
Tested in:
Firefox
✔️Chromium
✔️SQLite
✔️Mysql
✔️Postgres
✔️