fix: only use the configured hostname for opensearch output #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reload_* options tell fluentd to ask the Opensearch Nodes API for endpoint IP addresses to add to the round-robin pool for outbound connections. This behaviour is never correct in our configuration because we use TLS, and the certificate only has the configured hostname, not the pod IPs. So this change configures fluentd to only use the configured hostname.
tobybellwood
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reload_* options tell fluentd to ask the Opensearch Nodes API for
endpoint IP addresses to add to the round-robin pool for outbound
connections. This behaviour is never correct in our configuration
because we use TLS, and the certificate only has the configured
hostname, not the pod IPs.
So this change configures fluentd to only use the configured hostname.