-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: raw binary files handling in request body #3734
base: main
Are you sure you want to change the base?
Conversation
@marcosadsj Thanks for your contribution to Bruno; we merged your PR into https://github.com/usebruno/bruno/tree/feat/raw-file-body, and I made some refactoring. It would be really helpful if you could review the changes in this #3829. |
Hello @sanjaikumar-bruno , it's a pleasure to contribute with this amazing tool. I will review the changes and provide a feedback as soon as possible. |
@sanjaikumar-bruno I just added one comment and one request changes, but looks really good for me! |
Hey @marcosadsj, thanks for taking the time to review the PR, but I’m not seeing any reviews that you suggested. Did you forget to press enter? Did you get the PR to your local and tested it? |
Sorry, I just forgot to submit the review 😅 |
@sanjaikumar-bruno Yes, I tested locally and realized that the payload was not sending, this is related to my request change. |
Description
Feature that implements the ability to add binary raw files in body request, that detects the content-type and ensures that large files will not crash or block the app.
I tried to follow the same pattern as the multipartform feature to maintain consistency in the code.
Resolves: #2700 #3718
Requirements:
Contribution Checklist: