Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix: make external paths relative to confdir, not srcdir #1378

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

chrisjsewell
Copy link
Member

Paths set in the conf.py should be relative to it, not to the srcdir.
Note, often confdir and srcdir are equivalent, but this is not always the case.

Paths set in the `conf.py` should be relative to it, not to the `srcdir`.
Often `confdir` and `srcdir` are equivalent, but this is not always the case.
@chrisjsewell chrisjsewell changed the title 🐛 Fix make external paths relative to confdir 🐛 Fix: make external paths relative to confdir, not srcdir Jan 6, 2025
@chrisjsewell chrisjsewell requested review from ubmarco and danwos January 6, 2025 19:06
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.98%. Comparing base (4e10030) to head (9623f36).
Report is 94 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1378      +/-   ##
==========================================
+ Coverage   86.87%   87.98%   +1.10%     
==========================================
  Files          56       60       +4     
  Lines        6532     7130     +598     
==========================================
+ Hits         5675     6273     +598     
  Misses        857      857              
Flag Coverage Δ
pytests 87.98% <100.00%> (+1.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisjsewell chrisjsewell merged commit 65c9f4d into master Jan 7, 2025
18 checks passed
@chrisjsewell chrisjsewell deleted the rel_json_path branch January 7, 2025 08:27
@chrisjsewell chrisjsewell restored the rel_json_path branch January 7, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants