Allow filter-func in need-pie to have multiple dots in the import path. #1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from multiple dot
for more information, see https://pre-commit.ci
|
Nice catch and the fix seems to be quite small :) However, can you please also add a test case for this use case, so that we know the fix is really working? If any help is needed, just let me know. |
for more information, see https://pre-commit.ci
danwos
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just changed the split of the path of filter-func to split on the first dot starting from the right.
This means anything to the right will be the function name and anything to the left will be the module import path
This Fix will close the issue #1372