Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Needs warnings extended with all needs #1248

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Needs warnings extended with all needs #1248

wants to merge 19 commits into from

Conversation

PhilipPartsch
Copy link
Contributor

implement #1238

PhilipPartsch and others added 10 commits August 27, 2024 09:15
@PhilipPartsch
Copy link
Contributor Author

@chrisjsewell could you please check the failing test? I am not sure to overcome this.
I think the rest is fine, could you review the rest?

@chrisjsewell
Copy link
Member

I think the rest is fine, could you review the rest?

Heya, I'm just working on the internal representation of needs (for scaling), and how it is exposed, so I would hold off on reviewing/merging this yet.
I understand the use-case though

@chrisjsewell
Copy link
Member

Heya, note you can now use https://sphinx-needs.readthedocs.io/en/latest/api.html#sphinx_needs.api.need.get_needs_view, to retrieve all needs

@PhilipPartsch
Copy link
Contributor Author

@chrisjsewell can we merge it now?

@PhilipPartsch PhilipPartsch mentioned this pull request Oct 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PhilipPartsch @chrisjsewell