👌 Exclude external needs from needs_id_regex check

[David-Le-Nir]

fix for #1099

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.90%. Comparing base (cf5598f) to head (8b355fb).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1108   +/-   ##
=======================================
  Coverage   85.90%   85.90%           
=======================================
  Files          56       56           
  Lines        6511     6511           
=======================================
  Hits         5593     5593           
  Misses        918      918           

Flag	Coverage Δ
pytests	85.90% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[danwos]

Thanks for the quick PR 👍

The change in need.py looks good, as well as the updated test case.

However, I think we need to clean this PR a little bit. :)

Version changes are introduced by a separate PR. Makes it easier to rewind single commits. So please remove this.

.DS_Store and sphinxcontrib-needs.iml are also not needed.
It's okay to add them to .gitignore if it simplifies your life.

And it would be also good to add a small line to docs/changelog.rst for a 2.1.0 release.

[danwos]

Ohh and please ignore the failing pre-commit action.
Looks like a new mypy version finds much more now. I deal with this in a different PR and will merge this PR by hand.

[David-Le-Nir]

Version changes are introduced by a separate PR. Makes it easier to rewind single commits. So please remove this.

.DS_Store and sphinxcontrib-needs.iml are also not needed.
It's okay to add them to .gitignore if it simplifies your life.

And it would be also good to add a small line to docs/changelog.rst for a 2.1.0 release.

yes, sorry, my CLI shortcuts are a bit too "shortcutting" ... I'll fix that
yes, for the changelog, I didn't know which version to set. Also should I update the pyproject.toml to set 2.1.0 for version ?

[danwos]

No, we need to raise or better add the version just in the changelog.
All the other locations (pyproject.toml, needs.py, ...) will be done by a separate PR.

[danwos]

I was asked by @chrisjsewell to hold this PR back for some time.
He may have some concerns but is sitting on a train right now.

[chrisjsewell]

This is all good thanks, if you can apply the changes and fix the merge conflicts

[chrisjsewell]

cheers