exclude needs under only directive if required #1106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danwos
requested changes
Feb 12, 2024
There was a problem hiding this comment.
Please see also my comment in the related issue: #1103 (comment)
sphinx_needs/directives/need.py
Outdated
| @@ -356,6 +359,16 @@ def previous_sibling(node: nodes.Node) -> Optional[nodes.Node]: | |||
| return node.parent[i - 1] if i > 0 else None # type: ignore | |||
|
|
|||
|
|
|||
| def need_node_excluded_by_only_directive(env: BuildEnvironment, node: nodes.Node) -> bool: | |||
| """Return True if the node is under an "only" directive that shall be excluded given to the current tags""" | |||
| if hasattr(node.parent, "tagname") and node.parent.tagname == "only": | |||
There was a problem hiding this comment.
I guess this would not support nested needs or needs in other directives like container, list-table and co.
David-Le-Nir
force-pushed
the
fix/issue_1103_only_exclusion
branch
2 times, most recently
from
cf51427 to
7afd6ea
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1106 +/- ##
==========================================
+ Coverage 83.83% 83.87% +0.03%
==========================================
Files 56 56
Lines 6429 6442 +13
==========================================
+ Hits 5390 5403 +13
Misses 1039 1039
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
David-Le-Nir
force-pushed
the
fix/issue_1103_only_exclusion
branch
5 times, most recently
from
fd3343b to
7d783c0
Compare
David-Le-Nir
force-pushed
the
fix/issue_1103_only_exclusion
branch
from
7d783c0 to
eda2264
Compare
chrisjsewell
changed the title
|
Covered by #1112 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #1103