Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧪 Test README builds in pre-commit #1069

Merged
merged 1 commit into from
Nov 13, 2023
Merged

🧪 Test README builds in pre-commit #1069

merged 1 commit into from
Nov 13, 2023

Conversation

chrisjsewell
Copy link
Member

The v2.0.0 failed to publish 🙈, see https://github.com/useblocks/sphinx-needs/actions/runs/6851896295/job/18629213955

I believe this should be the fix.
Not sure if there is any better way to pre-check the deployment?

@chrisjsewell chrisjsewell requested a review from danwos November 13, 2023 15:44
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@4c83692). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1069   +/-   ##
=========================================
  Coverage          ?   79.27%           
=========================================
  Files             ?       56           
  Lines             ?     6460           
  Branches          ?        0           
=========================================
  Hits              ?     5121           
  Misses            ?     1339           
  Partials          ?        0           
Flag Coverage Δ
pytests 79.27% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@danwos danwos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love that you always create a CI update to test stuff automatically, instead of fixing only the problem :)

The solution is totally okay for me, as I hope that changes and problems are not happening too often in the README file.

@chrisjsewell
Copy link
Member Author

chrisjsewell commented Nov 13, 2023

I love that you always create a CI update to test stuff automatically, instead of fixing only the problem :)

Aha, thanks have to protect against my human error 😅

@chrisjsewell chrisjsewell merged commit 83d0934 into master Nov 13, 2023
16 checks passed
@chrisjsewell chrisjsewell deleted the test-readme branch November 13, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants