Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧪 Testing of JS scripts using Cypress integrated into PyTest #1051

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

iSOLveIT
Copy link
Collaborator

@iSOLveIT iSOLveIT commented Oct 24, 2023

The changes included are:

  • Updated conftest.py to enable JS testing using Cypress and PyTest.
  • Added make test-js command to Makefile.

NOTE: This is an improved version of PR #1007 which is closed due to commit conflicts and rebase issues.

@iSOLveIT iSOLveIT requested a review from danwos October 24, 2023 15:39
@iSOLveIT iSOLveIT changed the title Testing of JS scripts using Cypress integrated into PyTest 🧪 Testing of JS scripts using Cypress integrated into PyTest Oct 24, 2023
@iSOLveIT iSOLveIT self-assigned this Oct 24, 2023
@iSOLveIT iSOLveIT marked this pull request as ready for review October 26, 2023 05:25
Copy link
Member

@danwos danwos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🚀
Found only some rst-style stuff.
And I'm not sure how to deal with the jquery file. Is it really needed?

docs/contributing.rst Outdated Show resolved Hide resolved
docs/contributing.rst Outdated Show resolved Hide resolved
docs/contributing.rst Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
sphinx_needs/libs/html/jquery-3.6.0.min.js Outdated Show resolved Hide resolved
@iSOLveIT
Copy link
Collaborator Author

iSOLveIT commented Oct 26, 2023

And I'm not sure how to deal with the jquery file. Is it really needed?

I added the jquery file for Sphinx versions >5 because the PyTest Js test cases will fail since it needs Jquery to be present.

Although, I came across a Sphinx control-jquery package which adds Jquery support for Sphinx>5 so I will try that out first before finalizing the PR.

…es are:

- Updated conftest.py to enable JS testing using Cypress and PyTest.
- Added ``make test-js`` command to Makefile.
@iSOLveIT iSOLveIT requested a review from danwos October 26, 2023 14:08
@danwos danwos merged commit e37896d into master Nov 2, 2023
@danwos danwos deleted the generic-SN-JS-test branch November 2, 2023 09:59
chrisjsewell added a commit that referenced this pull request Nov 3, 2023
In #1051 setting of the `plantuml` config option was moved centrally into `test_app`.
This commit removes the config from individual `conf.py`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants