-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧪 Testing of JS scripts using Cypress integrated into PyTest #1051
Conversation
b11af1e
to
dd42ab2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 🚀
Found only some rst-style stuff.
And I'm not sure how to deal with the jquery file. Is it really needed?
I added the jquery file for Sphinx versions >5 because the PyTest Js test cases will fail since it needs Jquery to be present. Although, I came across a Sphinx control-jquery package which adds Jquery support for Sphinx>5 so I will try that out first before finalizing the PR. |
…es are: - Updated conftest.py to enable JS testing using Cypress and PyTest. - Added ``make test-js`` command to Makefile.
dd42ab2
to
8b2cf8b
Compare
In #1051 setting of the `plantuml` config option was moved centrally into `test_app`. This commit removes the config from individual `conf.py`
The changes included are:
make test-js
command to Makefile.NOTE: This is an improved version of PR #1007 which is closed due to commit conflicts and rebase issues.