ink_2e2 event decode #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is still somewhat WIP at moment, waiting on PR ganesh1997oli#1 introducing improvements on presentation and testing capabilities, including README. |
Revisions to e2e event testing
|
User @blairmunroakusa, please sign the CLA here. |
|
Cla signed, and PR no longer WIP. |
ascjones
reviewed
Mar 15, 2023
There was a problem hiding this comment.
Perhaps this belongs better in https://github.com/paritytech/ink/tree/master/integration-tests?
I believe the idea for this repo is to have "real world" examples, whereas ink/integration-tests contains more feature specific "examples".
|
@ascjones I like the sounds of that much better! I will open PR there, unless you have any other insights/suggestions. |
|
@blairmunroakusa: yes, please open a PR in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add event decode testing for unit test and e2e_test as per discussion by @alessandro-baldassarre and @blairmunroakusa