Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update codeowners #1787

Merged
merged 1 commit into from
Nov 4, 2024

Update codeowners

4fd039e
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Update codeowners #1787

Update codeowners
4fd039e
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy failed Nov 4, 2024 in 0s

clippy

6 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 6
Warning 0
Note 0
Help 0

Versions

  • rustc 1.82.0 (f6e511eec 2024-10-15)
  • cargo 1.82.0 (8f40fc59f 2024-08-21)
  • clippy 0.1.82 (f6e511e 2024-10-15)

Annotations

Check failure on line 766 in crates/build/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `map_err` over `inspect_err` 

error: using `map_err` over `inspect_err`
   --> crates/build/src/lib.rs:766:75
    |
766 |                 local_build(&crate_metadata, &optimization_passes, &args).map_err(
    |                                                                           ^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect
help: try
    |
766 ~                 local_build(&crate_metadata, &optimization_passes, &args).inspect_err(
767 |                     |e| {
768 |                         // build error -> bundle is stale
769 ~                         clean_metadata();
    |

Check failure on line 766 in crates/build/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `map_err` over `inspect_err` 

error: using `map_err` over `inspect_err`
   --> crates/build/src/lib.rs:766:75
    |
766 |                 local_build(&crate_metadata, &optimization_passes, &args).map_err(
    |                                                                           ^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect
help: try
    |
766 ~                 local_build(&crate_metadata, &optimization_passes, &args).inspect_err(
767 |                     |e| {
768 |                         // build error -> bundle is stale
769 ~                         clean_metadata();
    |

Check failure on line 221 in crates/build/src/docker.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `map` over `inspect` 

error: using `map` over `inspect`
   --> crates/build/src/docker.rs:221:43
    |
221 |     build_result.metadata_result.as_mut().map(|m| {
    |                                           ^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect
    = note: `-D clippy::manual-inspect` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::manual_inspect)]`
help: try
    |
221 ~     build_result.metadata_result.as_mut().inspect(|m| {
222 |         m.dest_bundle = host_folder.join(
...
232 |                 .expect("cannot strip prefix"),
233 ~         );
    |

Check failure on line 766 in crates/build/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `map_err` over `inspect_err` 

error: using `map_err` over `inspect_err`
   --> crates/build/src/lib.rs:766:75
    |
766 |                 local_build(&crate_metadata, &optimization_passes, &args).map_err(
    |                                                                           ^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect
help: try
    |
766 ~                 local_build(&crate_metadata, &optimization_passes, &args).inspect_err(
767 |                     |e| {
768 |                         // build error -> bundle is stale
769 ~                         clean_metadata();
    |

Check failure on line 221 in crates/build/src/docker.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `map` over `inspect` 

error: using `map` over `inspect`
   --> crates/build/src/docker.rs:221:43
    |
221 |     build_result.metadata_result.as_mut().map(|m| {
    |                                           ^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect
    = note: `-D clippy::manual-inspect` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::manual_inspect)]`
help: try
    |
221 ~     build_result.metadata_result.as_mut().inspect(|m| {
222 |         m.dest_bundle = host_folder.join(
...
232 |                 .expect("cannot strip prefix"),
233 ~         );
    |

Check failure on line 221 in crates/build/src/docker.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `map` over `inspect` 

error: using `map` over `inspect`
   --> crates/build/src/docker.rs:221:43
    |
221 |     build_result.metadata_result.as_mut().map(|m| {
    |                                           ^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect
    = note: `-D clippy::manual-inspect` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::manual_inspect)]`
help: try
    |
221 ~     build_result.metadata_result.as_mut().inspect(|m| {
222 |         m.dest_bundle = host_folder.join(
...
232 |                 .expect("cannot strip prefix"),
233 ~         );
    |
View more details on GitHub Actions