Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

embedding support #21

Merged
merged 10 commits into from
Apr 15, 2024
Merged

embedding support #21

merged 10 commits into from
Apr 15, 2024

Conversation

burak-upstash
Copy link
Collaborator

No description provided.

@linear Linear
Copy link

linear bot commented Apr 3, 2024

DX-814 vector-py - embedding support

CahidArda
CahidArda reviewed Apr 3, 2024
View reviewed changes
tests/core/test_query.py Outdated Show resolved Hide resolved
tests/core/test_query.py Show resolved Hide resolved
mdumandag
mdumandag reviewed Apr 3, 2024
View reviewed changes
upstash_vector/core/index_operations.py Outdated Show resolved Hide resolved
tests/core/test_upsert.py Outdated Show resolved Hide resolved
upstash_vector/types.py Outdated Show resolved Hide resolved
upstash_vector/core/index_operations.py Outdated Show resolved Hide resolved
upstash_vector/core/index_operations.py Outdated Show resolved Hide resolved
upstash_vector/core/index_operations.py Outdated Show resolved Hide resolved
@CahidArda
Copy link
Collaborator

CahidArda commented Apr 4, 2024 •
edited
Loading

couldn't run tests because I am unable to create a vector db temporarily. let's wait until we pass the tests

edit: tests were run succefully.

mdumandag
mdumandag reviewed Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@mdumandag mdumandag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented only on the sync versions of the methods, but please apply them to async methods as well

upstash_vector/core/index_operations.py Outdated Show resolved Hide resolved
upstash_vector/core/index_operations.py Outdated Show resolved Hide resolved
upstash_vector/core/index_operations.py Outdated Show resolved Hide resolved
upstash_vector/core/index_operations.py Outdated Show resolved Hide resolved
upstash_vector/utils.py Outdated Show resolved Hide resolved
upstash_vector/utils.py Outdated Show resolved Hide resolved
mdumandag
mdumandag reviewed Apr 15, 2024
View reviewed changes
upstash_vector/utils.py Outdated Show resolved Hide resolved
upstash_vector/utils.py Outdated Show resolved Hide resolved
@burak-upstash burak-upstash merged commit 9f7a1d3 into master Apr 15, 2024
1 check passed
@mdumandag mdumandag deleted the dx-814 branch April 15, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CahidArda CahidArda CahidArda left review comments

@mdumandag mdumandag mdumandag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@burak-upstash @CahidArda @mdumandag